On Thu, Sep 18, 2014 at 11:39:44AM +0200, Jeroen Hofstee wrote:
Hello Masahiro,
On 18-09-14 04:14, Masahiro Yamada wrote:
Since clang has a different definition for uninitialized_var it will complain that it is redefined in include/compiler.h. Since these are already defined in linux/compiler.h just remove this instance.
Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Tom Rini trini@ti.com Signed-off-by: Jeroen Hofstee jeroen@myspectrum.nl
I don't mind this patch but it has made me realize another problem.
We have both include/compiler.h and include/linux/compiler.h. Some sources use tha former and others use the latter.
I don't know how to use the right one in the right place.
no me neither, although it seems arch / drivers tend to use linux/compiler.h more while tools include compiler.h more.
My first guess is that we can't as easily throw <linux/compiler.h> into tools and thus need that around just for tools. Perhaps we should note as much in <compiler.h> and fix regular code to use <linux/compiler.h> ?