On Friday 04 September 2020 17:36:18 Andre Heider wrote:
On 04/09/2020 14:40, Stefan Roese wrote:
Hi Andre,
On 04.09.20 14:35, Andre Heider wrote:
<snip>
First I though that you have been syncing the file with the Linux kernel version. But now I see that its sync'ed with downstream U-Boot most likely. As for the license of the file: The Linux kernel version has this SPDX tag:
// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
Changing this to this tag would haven been fine (AFAICT). But using a diffent one from a downstream U-Boot repository is a bit troublesome for my taste.
Can't you sync with Linux dts/dtsi files instead at some point?
at some point, yes. As far as I understand that's not yet possible due to the comphy driver. Quoting Marek's cover letter "[PATCH u-boot-marvell 00/11] Armada 37xx: port comphy to generic-phys (PLEASE TEST)" from 19th April:
> I have ported the COMPHY and UTMI PHY drivers from Linux to U-Boot. > With this we are able to abandon the current comphy_a3700 driver, which > is incompatible with Linux' device trees. So if we want to have DTS > files for A3720 boards identical to Linux', we have to do this.
So unfortunately we can't use Linux' dts files for a3700 yet. Marek said he plans to work on that set again in the near future, so hopefully that lands rather sooner than later ;)
Ah, thanks. I remember now. ;)
Can you then please drop the sync with the downstream dts and better only make the necessary changes for eMMC? In a git bisectable way please?
Sure, I've just sent v2, completely redone. That also prepares synching from Linux, actually already imports two dts from from there.
So synchronization with Linux DTS files needs to wait until Armada comphy patches are finished and merged into mainline U-Boot.