22 Oct
2019
22 Oct
'19
12:53 a.m.
Hi Andy,
On Mon, 21 Oct 2019 at 02:49, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Mon, Oct 21, 2019 at 7:14 AM Simon Glass sjg@chromium.org wrote:
Adds a driver for the apollolake Primary-to-sideband bus. This supports various child devices. It supposed both device tree and of-platdata.
+static int apl_p2sb_probe(struct udevice *dev) +{
if (spl_phase() == PHASE_TPL)return apl_p2sb_early_init(dev);
else if (spl_phase() == PHASE_SPL)Redundant 'else' (recommended to check for a such in the entire series)
This is a style thing. I like the else so that it is clear that we have two options. I could use a switch() but then it needs to have a 'default' which is ugly.
return apl_p2sb_spl_init(dev);return 0;+}
Regards, Simon