On Nov 30, 2007, at 4:34 PM, Timur Tabi wrote:
Kumar Gala wrote:
+U_BOOT_CMD(
- qe, 4, 0, qe_cmd,
- "qe - QUICC Engine commands\n",
- "fw <addr> [<length>] - Upload firmware at address <addr>,\n"
I'm at a loss, why have length at all? You seem to always take it from firmware->header.length.
It's optional. If you specify the length, it will validate that against header.length. That's so that you can do this:
tftp $loadaddr $firmware qe fw $loadaddr $filesize
If the length doesn't match, then it doesn't bother trying to parse the rest of the image.
The Linux version of this code does the same thing, but it's probably more useful since drivers will use request_firmware() which returns a length.
Granted, the CRC check is more bullet-proof.
It seems like a silly check if there is already a CRC check.
Also can we be more explicit in the help with 'Upload firmware'.. to 'Upload microcode firmware to QE' or something like that.
Sure. New patch coming.
- k