Hi Heinrich,
On Wed, 1 Dec 2021 at 11:14, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 12/1/21 17:02, Simon Glass wrote:
At present this option is missing a header file, a function prototype and the qfw driver needs a header included.
Fix these problems so we can enable this option on sandbox. This will increase the build coverage.
Signed-off-by: Simon Glass sjg@chromium.org
arch/sandbox/include/asm/acpi_table.h | 2 ++ arch/sandbox/include/asm/tables.h | 0 drivers/misc/qfw.c | 1 + 3 files changed, 3 insertions(+) create mode 100644 arch/sandbox/include/asm/tables.h
diff --git a/arch/sandbox/include/asm/acpi_table.h b/arch/sandbox/include/asm/acpi_table.h index 921c7f4201d..ae17f6c5197 100644 --- a/arch/sandbox/include/asm/acpi_table.h +++ b/arch/sandbox/include/asm/acpi_table.h @@ -6,4 +6,6 @@ #ifndef __ASM_ACPI_TABLE_H__ #define __ASM_ACPI_TABLE_H__
+ulong write_acpi_tables(ulong start);
This definition should be in a global include. The parameter must a pointer to restrict sandbox specific code to the sandbox.
Yes indeed, I meant to fix the header before sending but missed it. Will fix.
It doesn't really help making it a pointer, even if I wanted to, which I don't, sorry. We still need to print out the address, and pass it on to other functions, so if we pass a pointer we just need to convert back to an address for that purpose.
Regards, Simon