Hi, Stefano,
2010/12/28 Stefano Babic sbabic@denx.de:
On 12/28/2010 09:12 AM, Jason Liu wrote:
A general remark. You posted two different patchset now to support the MX53 processor. As the patches are related, please combine all patches in a single patchset to avoid that only a few of them go to be applied and to simplify review.
The patch for support mx53 processor is tracked by version. Sorry, I don't catch your mean. Thanks in advance for telling me clear on that if something wrong.
Patches for mx53evk are in one patchset, but they depends on patches you sent in another patchset (for pmic, gpio,). All patches that belong to the same patchset are merged together into the mainline, avoiding conflicts and board breakages. If for example your first patchset is merged, but the second one is waiting for changes, the board cannot be compiled clean and can potentially break other board, if for example it contains a partial modification that is fixed in the second patchset. Increase the version number and put all related patches in the same patchset.
OK, I get it. Thanks for the clarification.
Best regards, Stefano Babic
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================