Why is that so bad? It makes it possible to debug U-Boot with just loading the image into RAM using BDI2000.
Which is an unsupported mode of operation which works for a handfull of experts and causes confusion with many, many newbees.
How do these lines of code confuse a newbie more than any other code in the file?
But how would you debug U-Boot?
As I always do. Attach the BDI, burn to flash, start in GDB.
There are 53982 other hardware debuggers out there and only the minority (is there actually one besides the BDI?) support the burn to flash feature you rely on. So if you need to start U-Boot to flash U-Boot, you either do those few lines of code to skip the relocation or get/use another piece of actually redundant software to get the image on the flash. I don't know why the latter should save me time.
You can do this if you know exactly what you're doing,
Isn't this what is assumed here anyway?
Best regards, Lars Friedrich