Re: [U-Boot] [PATCH v2 4/4] mx23_olinuxino: Add ethernet support

Dear Otavio Salvador, [...]

diff --git a/board/olimex/mx23_olinuxino/spl_boot.c b/board/olimex/mx23_olinuxino/spl_boot.c index 3bbf5ad..8f7ba0b 100644 --- a/board/olimex/mx23_olinuxino/spl_boot.c +++ b/board/olimex/mx23_olinuxino/spl_boot.c @@ -95,6 +95,10 @@ const iomux_cfg_t iomux_setup[] = { MX23_PAD_SSP1_DATA2__SSP1_DATA2 | MUX_CONFIG_SSP, MX23_PAD_SSP1_DATA3__SSP1_DATA3 | MUX_CONFIG_SSP, MX23_PAD_SSP1_SCK__SSP1_SCK | MUX_CONFIG_SSP,

• /* Ethernet */
• MX23_PAD_GPMI_ALE__GPIO_0_17 |

• (MXS_PAD_12MA | MXS_PAD_3V3),
  

PULLUP/NOPULL missing

};

void board_init_ll(void)

[...]

@@ -175,6 +183,7 @@ /*

• Extra Environments

*/

Spurious newline

#define CONFIG_EXTRA_ENV_SETTINGS \ "update_sd_firmware_filename=u-boot.sd\0" \ "update_sd_firmware=" /* Update the SD firmware partition */ \ @@ -191,6 +200,7 @@ "fdt_file=imx23-olinuxino.dtb\0" \ "fdt_addr=0x41000000\0" \ "boot_fdt=try\0" \

• "ip_dyn=yes\0" \ "mmcdev=0\0" \ "mmcpart=2\0" \ "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \

@@ -216,6 +226,31 @@ "fi; " \ "else " \ "bootm; " \

• "fi;\0" \
  

• "netargs=setenv bootargs console=${console_mainline},${baudrate} " \

• "root=/dev/nfs " \
  

• "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
  

• "netboot=echo Booting from net ...; " \

• "usb start; " \
  

• "run netargs; "	\
  

• "if test ${ip_dyn} = yes; then " \
  

• 	"setenv get_cmd dhcp; " \
  

• "else " \
  

• 	"setenv get_cmd tftp; " \
  

• "fi; " \
  

• "${get_cmd} ${uimage}; " \
  

• "if test ${boot_fdt} = yes; then " \
  

• 	"if ${get_cmd} ${fdt_addr} ${fdt_file}; then " \
  

• 		"bootm ${loadaddr} - ${fdt_addr}; " \
  

• 	"else " \
  

• 		"if test ${boot_fdt} = try; then " \
  

• 			"bootm; " \
  

• 		"else " \
  

• 			"echo WARN: Cannot load the DT; " \
  

• 		"fi;" \
  

• 	"fi; " \
  

• "else " \
  

• 	"bootm; " \
  

  "fi;\0"

#define CONFIG_BOOTCOMMAND \ @@ -225,10 +260,9 @@ "else " \ "if run loaduimage; then " \ "run mmcboot; " \

• 	"else " \
  

• 		"echo ERR: Fail to boot from MMC; " \
  

• 	"else run netboot; " \
  "fi; " \
  

  "fi; " \

• "else exit; fi"

• "else run netboot; fi"

#endif /* __MX23_OLINUXINO_CONFIG_H__ */

Best regards, Marek Vasut