Thanks Tom.
On 28 September 2015 at 16:10, Tom Rini trini@konsulko.com wrote:
On Wed, Sep 23, 2015 at 10:25:35AM -0700, Ryan Harkin wrote:
As config migrates from board config files to Kconfig, when adding CONFIG_SYS_BOOTM_LEN to a platform, I decided to add Kconfig support for CONFIG_SYS_BOOTM_LEN.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org Reviewed-by: Linus Walleij linus.walleij@linaro.org CC: Masahiro Yamada yamada.m@jp.panasonic.com CC: Simon Glass sjg@chromium.org CC: Linus Walleij linus.walleij@linaro.org
Thanks for trying to do this. The problem however is that you need to use tools/moveconfig.py so that all of the other boards (which is a lot) get updated too, otherwise they fail to build.
Yes, I just read another email on the list about using moveconfig.py. That's a big job, as you say.
Since that's kind of a big thing, can you split this series into a v2 of things which really should be in before the release, and then nice cleanups like this which can go in once the merge window is open again?
Thanks!
So I should post a v2 that uses CONFIG_SYS_BOOTM_LEN like all the other boards for now? Then submit a new series to use moveconfig.py to Kconfig?
I already tried using moveconfig.py for this and it fails on every instance, from what I can tell. I think the other board configs using the shift operation makes this tricky.
I guess there are two options: make Kconfig support complex values (eg. to allow << operators, etc.) or convert all the other boards to use absolute values. Of course, another option is to leave it alone.
-- Tom