25 Apr
2010
25 Apr
'10
8:14 p.m.
Dear Thomas Chou,
In message 4BD377C9.6010809@wytron.com.tw you wrote:
The convention is not to add unused code. If there are no real users for this, the patch should be delayed until a board gets added that actually uses it.
These nios2 boards are now supported with the nios2-generic board approach, like that of microblaze-generic, instead of adding every nios2 board to u-boot mainline. The nios2-generic board patch was applied to Scott's next branch.
The gpio led can be enabled with the following added to the board config file.
As long as no board actually uses this code we should put that patch on hold. Please resubmit it as part of the patch series that adds the first board that uses this code. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It's all Klatchian to me.
- Terry Pratchett & Stephen Briggs, _The Discworld Companion_