Re: [U-Boot] [patch] break build if it would produce broken binary

On Mon, Apr 13, 2015 at 02:49:28PM +0200, Pavel Machek wrote:

Add an error in known-bad case so that we don't produce broken and hard to debug binaries.

Signed-off-by: Pavel Machek pavel@denx.de

diff --git a/arch/arm/include/asm/u-boot.h b/arch/arm/include/asm/u-boot.h index 43cc494..ae4c21b 100644 --- a/arch/arm/include/asm/u-boot.h +++ b/arch/arm/include/asm/u-boot.h @@ -49,4 +49,8 @@ typedef struct bd_info { #define IH_ARCH_DEFAULT IH_ARCH_ARM64 #endif

+#if defined(CONFIG_USE_PRIVATE_LIBGCC) && defined(CONFIG_SYS_THUMB_BUILD) +#error Thumb build does not work with private libgcc. +#endif

#endif /* _U_BOOT_H_ */

I'm agreeable to taking this for the release if you'll go and debug what's wrong with our private libgcc code for the next release.