24 Apr
2009
24 Apr
'09
9:54 p.m.
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090405085601.GA31840@game.jcrosoft.org you wrote:
diff --git a/common/modem.c b/common/modem.c new file mode 100644 index 0000000..27e164a --- /dev/null +++ b/common/modem.c
...
+/* called from main loop (common/main.c) */ +/* 'inline' - We have to do it fast */ +static inline void mdm_readline(char *buf, int bufsiz)
How is this supposed to work? You cannot call a static function from another source file.
this function is only use in this file
actualy the code is lib_arm/board.c and lib_ppc/board.c is identical
I just move it to modem.c
the only function use outiside of this file is mdm_init
Then please fix the comment - it says: "called from main loop (common/main.c)"
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Winners never talk about glorious victories. That's because they're
the ones who see what the battlefield looks like afterwards. It's
only the losers who have glorious victories.
- Terry Pratchett, _Small Gods_