On Thursday 12 November 2009 08:35:08 Mike Rapoport wrote:
Mike Frysinger wrote:
On Wednesday 11 November 2009 03:03:00 Mike Rapoport wrote:
--- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -243,7 +243,7 @@ dev = malloc(sizeof(*dev)); if (!dev) { free(dev);
return 0;
return -1;this is correct as this is an error
@@ -252,7 +252,7 @@ /* Try to detect chip. Will fail if not present. */ if (smc911x_detect_chip(dev)) { free(dev);
return 0;
return -1;this is not -- we want it to return 0 if no parts are found. see recent net doc updates and discussions.
Hope this one is better:
From 4a9420704dd81a08f950017d365e0826880536ed Mon Sep 17 00:00:00 2001 From: Mike Rapoport mike@compulab.co.il Date: Tue, 10 Nov 2009 15:31:46 +0200 Subject: [PATCH] smc911x: make smc911x_initialize return correct value
Make smc911x_initialize return -1 on error and number of interfaces detected otherwise.
Acked-by: Mike Frysinger vapier@gentoo.org -mike