Re: [U-Boot] [PATCH 2/2] mmc: rpmb: update size format for write_counter

On 7 June 2017 at 19:20, Kever Yang kever.yang@rock-chips.com wrote:

According to MMC spec, the write_counter is 4-byte length, use 'int' instead of 'long' type for the 'long' is not 4-byte in 64 bit CPU.

Signed-off-by: Jason Zhu jason.zhu@rock-chips.com Signed-off-by: Kever Yang kever.yang@rock-chips.com

---

drivers/mmc/rpmb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

So should we use uint32_t?

diff --git a/drivers/mmc/rpmb.c b/drivers/mmc/rpmb.c index 1c6888f..0b6b622 100644 --- a/drivers/mmc/rpmb.c +++ b/drivers/mmc/rpmb.c @@ -67,7 +67,7 @@ struct s_rpmb { unsigned char mac[RPMB_SZ_MAC]; unsigned char data[RPMB_SZ_DATA]; unsigned char nonce[RPMB_SZ_NONCE];

•   unsigned long write_counter;
  

•   unsigned int write_counter;
    unsigned short address;
    unsigned short block_count;
    unsigned short result;
  

-- 1.9.1