Hi Akshay,
On 21 May 2014 23:23, Akshay Saraswat akshay.s@samsung.com wrote:
This board is based on Exynos5420 and is similar to SMDK5420 board. Adding new and refactoring existing DT and config files to support both SMDK5420 and Peach-Pit.
Changes since v1: - Added "Acked-by".
One more thing I noticed - the first commit gives a build error:
02: Exynos5420: Introduce support for the Peach-Pit board -make: *** No rule to make target `peach-pit_config'. Stop. -make[1]: *** [peach-pit_config] Error 1 +In file included from include/asm/arch/cpu.h:181:0, + from /home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/include/configs/exynos5-dt.h:17, + from /home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/include/configs/peach-pit.h:12, + from include/config.h:10, + from /home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c:9: +/home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c: In function ‘ddr3_mem_ctrl_init’: +/home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c:406:10: error: ‘PAD_RETENTION_DRAM_COREBLK_VAL’ undeclared (first use in this function) + writel(PAD_RETENTION_DRAM_COREBLK_VAL, + ^ +/home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/arch/arm/include/asm/io.h:141:34: note: in definition of macro ‘writel’ + #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; }) + ^ +/home/sjg/c/src/third_party/u-boot/try-pit/.bm-work/00/arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c:406:10: note: each undeclared identifier is reported only once for each function it appears in +make[3]: *** [spl/arch/arm/cpu/armv7/exynos/dmc_init_ddr3.o] Error 1 +make[2]: *** [spl/arch/arm/cpu/armv7/exynos] Error 2 +make[1]: *** [spl/u-boot-spl] Error 2
It is fixed by the second commit.
Akshay Saraswat (2): Exynos5420: Introduce support for the Peach-Pit board Exynos5420: Let macros be used for exynos5420
arch/arm/cpu/armv7/exynos/exynos5_setup.h | 6 +- arch/arm/dts/Makefile | 3 +- arch/arm/dts/exynos5420-peach-pit.dts | 127 +++++++++++++++++++++++++ arch/arm/dts/exynos5420-smdk5420.dts | 23 +---- arch/arm/dts/exynos5420.dtsi | 70 -------------- arch/arm/dts/exynos54xx.dtsi | 151 ++++++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/exynos5420.h | 46 +++++++++ include/configs/peach-pit.h | 27 ++++++ include/configs/smdk5420.h | 49 ++-------- 10 files changed, 367 insertions(+), 136 deletions(-) create mode 100644 arch/arm/dts/exynos5420-peach-pit.dts delete mode 100644 arch/arm/dts/exynos5420.dtsi create mode 100644 arch/arm/dts/exynos54xx.dtsi create mode 100644 include/configs/exynos5420.h create mode 100644 include/configs/peach-pit.h
-- 1.8.3.2
Regards, Simon