-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/17/12 00:05, Peter Korsgaard wrote:
"Tom" == Tom Rini trini@ti.com writes:
Tom> At some point the am335x evm hardware was updated to previosly Tom> used in all other designs layout, so remove the now incorrect Tom> code.
Could we please just put it under a different symbol, E.G. CONFIG_OMAP3_SPI_SWAPPED? The board I'm working on uses the same wiring as the old evm (E.G. transmit on D0 and receive on D1).
Tom> Signed-off-by: Tom Rini trini@ti.com Tom> --- Tom> drivers/spi/omap3_spi.c | 10 ---------- Tom> 1 file changed, 10 deletions(-)
Tom> diff --git a/drivers/spi/omap3_spi.c b/drivers/spi/omap3_spi.c Tom> index e40a632..47f9e56 100644 Tom> --- a/drivers/spi/omap3_spi.c Tom> +++ b/drivers/spi/omap3_spi.c Tom> @@ -173,18 +173,8 @@ int spi_claim_bus(struct spi_slave *slave) Tom> /* standard 4-wire master mode: SCK, MOSI/out, MISO/in, nCS Tom> * REVISIT: this controller could support SPI_3WIRE mode. Tom> */ Tom> -#ifdef CONFIG_AM33XX Tom> - /* Tom> - * The reference design on AM33xx has D0 and D1 wired up opposite Tom> - * of how it has been done on previous platforms. We assume that Tom> - * custom hardware will also follow this convention. Tom> - */ Tom> - conf &= OMAP3_MCSPI_CHCONF_DPE0; Tom>
- conf |= ~(OMAP3_MCSPI_CHCONF_IS|OMAP3_MCSPI_CHCONF_DPE1);
The inversion seems wrong. DPE0 should be cleared and IS|DPE1 set.
Tom> -#else Tom> conf &= ~(OMAP3_MCSPI_CHCONF_IS|OMAP3_MCSPI_CHCONF_DPE1); Tom> conf |= OMAP3_MCSPI_CHCONF_DPE0; Tom> -#endif
Tom> /* wordlength */ Tom> conf &= ~OMAP3_MCSPI_CHCONF_WL_MASK;
Alright, can you post a patch that works for you? Thanks!
- -- Tom