Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

On 10/3/2023 1:40 PM, Keerthy wrote:

Enable ESM initialization for J7200

Signed-off-by: Keerthy j-keerthy@ti.com

board/ti/j721e/evm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 42fa94b7a5..070b28326f 100644 --- a/board/ti/j721e/evm.c +++ b/board/ti/j721e/evm.c @@ -543,7 +543,8 @@ void spl_board_init(void) }

#ifdef CONFIG_ESM_K3

• if (board_ti_k3_is("J721EX-PM2-SOM")) {

• if ((board_ti_k3_is("J721EX-PM2-SOM")) ||

•    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
  

Could we align on one kind of check,  For J721E check is done against board-id, whereas for J7200 checking

for config option.

ret = uclass_get_device_by_driver(UCLASS_MISC,
				  DM_DRIVER_GET(k3_esm), &dev);
if (ret)

@@ -557,7 +558,8 @@ void spl_board_init(void) #endif

#ifdef CONFIG_ESM_PMIC

• if (board_ti_k3_is("J721EX-PM2-SOM")) {

• if ((board_ti_k3_is("J721EX-PM2-SOM")) ||

•    IS_ENABLED(CONFIG_TARGET_J7200_R5_EVM)) {
  

  ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(pmic_esm), &dev);