On 2/9/20 11:21 PM, Sean Anderson wrote:
On 2/9/20 4:59 PM, Heinrich Schuchardt wrote:
If CONFIG_LOG=n, we should still output errors, warnings, notices, infos, and for DEBUG=1 also debug messages.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Why not just change the default for CONFIG_LOG to y? This is effectively the same, except it still allows users to completely disable logging altogether.
--Sean
I have tested your suggestion for qemu_arm64_defconfig:
Without my patch and CONFIG_LOG=n:
u-boot.bin 664200 bytes
With my patch and CONFIG_LOG=n:
u-boot.bin 664432 bytes
Without my patch but with CONFIG_LOG=y and CONFIG_CONSOLE=y:
u-boot.bin 666648 bytes
So your suggestion consumes 2216 additional bytes to produce the essentially the same console output.
IMHO CONFIG_LOG=y is currently only helpful in the following situation:
* You are debugging your board and want to interactively change logging levels. * You want to log to a remote syslog server.
Best regards
Heinrich