On May 26, 2010, at 9:38 PM, Jerry Van Baren wrote:
Wolfgang Denk wrote:
Dear Timur Tabi,
In message 1274308618-2974-1-git-send-email-timur@freescale.com you wrote:
Introduce function fdt_get_max_phandle(), which returns the largest value of all phandles in a device tree. This is useful for allocating a new phandle property, since all phandles must be unique.
Signed-off-by: Timur Tabi timur@freescale.com
include/libfdt.h | 20 ++++++++++++++++++++ lib/libfdt/fdt_ro.c | 17 +++++++++++++++++ 2 files changed, 37 insertions(+), 0 deletions(-)
Please submit as part of a patch / patch series that acrtually uses this feature. As is, it's just dead code that has no users.
I'm happy with this in principle, and will <ack> formally when the community is OK with the code change. It looks like a positive improvement to me, reducing complexity and addressing Timur/Freescale's needs. Anyway, I envision <acking> the patch and having FSL include it in whatever MPC8xxx patchset that actually needs the changes.
Thanks and best regards, gvb
We should NOT add code to libfdt if we can avoid it. We should be doing this in fdt_support.c. libfdt changes should first go to dtc.
- k