-----Original Message----- From: Sebastian Hesselbarth [mailto:sebastian.hesselbarth@gmail.com] Sent: 03 March 2013 17:07 To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Rabeeh Khoury; Albert Aribaud; Andy Fleming; Joe Hershberger; Daniel Stodden; Luka Perkov Subject: Re: [PATCH v3 02/10] GPIO: add gpio driver for Orion SoCs
On 02/11/2013 04:39 AM, Prafulla Wadaskar wrote:
-----Original Message----- From: Sebastian
Hesselbarth
[mailto:sebastian.hesselbarth@gmail.com] Sent: 17
January 2013 00:55 To: Sebastian Hesselbarth
Cc: u-boot@lists.denx.de; Rabeeh Khoury; Albert
Aribaud; Prafulla Wadaskar; Andy Fleming; Joe
Hershberger; Daniel Stodden; Luka Perkov Subject:
[PATCH v3 02/10] GPIO: add gpio driver for
Orion SoCs
This adds a gpio driver for Marvell Orion SoCs, i.e.
orion5x, kirkwood, dove. This is based on
kw_gpio but as gpio capabilities depend heavily on
the mpp configuration for dove, it allows to
set gpi/gpo capabilities from mpp. This should be
compatible with the current kw_gpio and
porting mpp of kirkwood and orion5x is appreciated.
Nack, your patch series is for dove, you shouldn't
add for orion, unless you are using it. If you
think this is common framework can be used across the
other marvell SoCs, we have strategy to
name it like mv_***
So you may name this driver as mv_gpio
Prafulla,
I still think that mv_ as a prefix is too short. Remember that Marvell also has pxa SoCs and with latest SoCs handling of gpio may change dramatically.
Dear Sabastian, We already have code with this naming convention sitting in u-boot from long, so to sync with that we should use "mv".
Pxa is handled separately at this moment, it is outside our scope at this moment. In case if it conflicts pxa developer may consider a prefix "mvpxa"
We should rather stick to orion_ for Orion5x, Kirkwood, Dove or move to mvebu_ for above plus Armada XP/370.
Orion_, Kirkwood_ fine with me, but mvebu doesn't sound good for dove (ebu is business unit name), if "dv" does not sound good then you can use "dove" prefix.
Shorter names gives smaller source code :-)
Regards... Prafulla . . .
Sebastian