Dear Simon Kagstrom,
In message 20090710092452.492dfafe@marrow.netinsight.se you wrote:
OK, I've tried looking around at how other boards do it, and at least the most similar (mv6436x_eth_initialize() for other Marvell boards) do it the same way as well as some others (ax88180.c).
Then those slipped through the review process. Patches to clean these up are welcome.
Should Linux otherwise read the passed U-boot environment and set it up by itself?
Unfortunately ARM Linux does not provide yet a standard way to pass the MAC address from the boot loader. In the long term this problem will be solved by using the device tree for ARM; in the meantime, some drivers use a "ethaddr=" command line parameter (but that will probably bring up discussions on the Linux front again).
Best regards,
Wolfgang Denk