Re: [PATCH v2 2/3] wandboard: Propagate the error on PMIC function failure

On Mon, Dec 9, 2019 at 9:20 PM Fabio Estevam festevam@gmail.com wrote:

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c index b2f961a7f0..7209cc8211 100644 --- a/board/wandboard/wandboard.c +++ b/board/wandboard/wandboard.c @@ -366,13 +366,13 @@ int power_init_board(void) ret = pmic_get("pfuze100@8", &dev); if (ret < 0) { printf("pmic_get() ret %d\n", ret);

•           return 0;
  

•           return ret;
  

Ops, we can't return error here because this causes issues on the boards without PMIC.

I will resend the series without this patch.

    }

    reg = pmic_reg_read(dev, PFUZE100_DEVICEID);
    if (reg < 0) {
            printf("pmic_reg_read() ret %d\n", reg);

•           return 0;
  

•           return ret;
    }
    printf("PMIC:  PFUZE100 ID=0x%02x\n", reg);
    with_pmic = true;
  

-- 2.17.1