
19 Jul
2016
19 Jul
'16
7:47 p.m.
Dear Adam,
In message BLU436-SMTP222E98D640B2559335122F3B9370@phx.gbl you wrote:
- int length = strlen(getenv("board_rev")) + strlen("-wandboard-rev") +
strlen(getenv("board_name")) + strlen(".dtb") + 1;
- fdtfile = malloc(length);
Don't you think you should add some error checking here? Each of the getenv() calls may fail, as well as the malloc() - and then?
As is: NAK!!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Which witch wished which wicked wish?