On Dec 2, 2010, at 8:26 PM, Peter Tyser wrote:
Hi Becky,
+/* Common ddr init for non-corenet fsl 85xx platforms */ +#ifndef CONFIG_FSL_CORENET +phys_size_t initdram(int board_type) +{
- phys_size_t dram_size = 0;
- puts("Initializing\n");
Any chance we can remove the puts() above? "DRAM:" is always printed out directly before initdram is called, so I don't think the "Initializing" message adds much benefit and slightly dirties the output. For reference:
That's fine with me.... does anybody object to this? It's certainly easy to change this now.
-Becky
I2C: ready DRAM: Initializing DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on) FLASH: Executed from FLASH1 FLASH: 256 MiB
vs
I2C: ready DRAM: DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on) FLASH: Executed from FLASH1 FLASH: 256 MiB
Otherwise it looked good. I tested on the xpedite5170 that was a corner case, and the xpedite5370 (mpc8572-based).
Acked-by: Peter Tyser ptyser@xes-inc.com Tested-by: Peter Tyser ptyser@xes-inc.com