Re: [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f()

Hello Simon,

On 11-07-14 06:23, Simon Glass wrote:

At present arm defines CONFIG_SYS_GENERIC_GLOBAL_DATA, meaning that the global_data pointer is set up in board_init_f(). However it is actually set up before this, it just isn't zeroed.

If we zero the global data before calling board_init_f() then we don't need to define CONFIG_SYS_GENERIC_GLOBAL_DATA.

Make this change (on arm32 only) to simplify the init process. I don't have the ability to test aarch64 yet.

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v3:

• Fix assembler code comment in crt0.S to say GD, not BSS
• Ensure that aarch64 stays as it was
• Add newline after clr_gd label
• Remove redundant mov r0, #0

Changes in v2: None

arch/arm/include/asm/config.h | 2 ++ arch/arm/lib/crt0.S | 9 +++++++++ 2 files changed, 11 insertions(+)

Looks good to me. I picked up this one instead of my memset version.

Thanks, Jeroen