Re: [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions

Dear Kim Phillips,

In message 20090218122152.7fbe1e25.kim.phillips@freescale.com you wrote:

...

this is my proposed fix:

In addition to the unnecessary overhead for the memory footprint there are other problems with that patch:

+#else +char NS16550_getc (NS16550_t com_port) { } +int NS16550_tstc (NS16550_t com_port) { }

If these functions are supposed to return "char" resp. "int", you will get casty compiler warnings with an empty function body.

Best regards,

Wolfgang Denk