On 20/04/2016 15:40, Simon Glass wrote:
Hi Tim,
On 7 April 2016 at 11:20, Tim Chick Tim.Chick@mediatek.com wrote:
Sorry for top posting. Not in the office at the moment.
Yes, I call debug_uart_init() before I have SDRAM, in lowlevel_init(). I need the debug uart to help me debug lowlevel_init!
The patch below fixes it, and keeps your change:
Yes your patch looks correct to me. I have also used the debug UART without a stack.
OK. What needs to be done to get it applied?
Shall I submit as a "normal" patch?
Thanks, Tim
Reviewed-by: Simon Glass sjg@chromium.org
Thanks, Tim
diff --git a/include/debug_uart.h b/include/debug_uart.h index 0d640b9..2980ae6 100644 --- a/include/debug_uart.h +++ b/include/debug_uart.h @@ -115,17 +115,23 @@ void printhex8(uint value);
- Now define some functions - this should be inserted into the serial
driver */ #define DEBUG_UART_FUNCS \
void printch(int ch) \+\
static inline void _printch(int ch) \ { \ if (ch == '\n') \ _debug_uart_putc('\r'); \ _debug_uart_putc(ch); \ } \\
void printch(int ch) \{ \_printch(ch); \} \+\ void printascii(const char *str) \ { \ while (*str) \
printch(*str++); \
_printch(*str++); \ } \\ static inline void printhex1(uint digit) \ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot