Re: [U-Boot] [PATCHv2 1/4] omap3: embedd gpmc_cs into gpmc config struct

Dear Jean-Christophe

...

#ifndef __ASSEMBLY__ +struct gpmc_cs {

• unsigned int config1; /* 0x00 */
• unsigned int config2; /* 0x04 */
• unsigned int config3; /* 0x08 */
• unsigned int config4; /* 0x0C */
• unsigned int config5; /* 0x10 */
• unsigned int config6; /* 0x14 */
• unsigned int config7; /* 0x18 */

why not an array so can use a loop as in enable_gpmc_cs_config()

i also thought about that. Config 1 to 7 are the names used by TI's processor manuals, replacing by an array would lead to 0 - 6. If this would only be used in enable_gpmc_cs_config that wouldn't bother much, but as it is also used in evm/evm.h for example i think it will bring more confusion than it helps to simplify the code.

best regards, Matthias