On Tue, Nov 22, 2016 at 3:24 PM, Tom Rini trini@konsulko.com wrote:
On Tue, Nov 22, 2016 at 01:38:39PM +0100, Maxime Ripard wrote:
From: Hans de Goede hdegoede@redhat.com
Enable the NAND and UBI support in the configuration header so that we can (finally) use it.
Signed-off-by: Hans de Goede hdegoede@redhat.com Signed-off-by: Maxime Ripard maxime.ripard@free-electrons.com
board/sunxi/Kconfig | 8 ++++++++ include/configs/sunxi-common.h | 14 ++++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index e1d4ab148f08..c6a620a20167 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -460,6 +460,14 @@ config AXP_GPIO ---help--- Say Y here to enable support for the gpio pins of the axp PMIC ICs.
+if NAND_SUNXI +config CMD_NAND
default y+config CMD_UBI
default y+endif
We want to move away from adding 'default y' to board/*/Kconfig and instead have 'default y if ...' where the option is declared. In this particular case we have a TODO of adding a NAND option that would be used to hide things like CMD_NAND and other sub-sections rather than using CMD_NAND for everything.
That said, we've just got 2 sunxi boards with NAND today right? Maybe we shouldn't make this default for all sunxi boards yet, yes? Thanks!
There might be a few more (I think CubieTruck has onboard nand for example) but at least in Fedora we don't support any of the devices running nand because of the support in generally isn't great yet.
Peter