21 May
2020
21 May
'20
12:15 p.m.
On 5/20/20 6:40 PM, Michael Walle wrote: [...]
/**
- usb_find_and_bind_driver() - Find and bind the right USB driver
@@ -502,13 +531,14 @@ static int usb_match_one_id(struct usb_device_descriptor *desc, static int usb_find_and_bind_driver(struct udevice *parent, struct usb_device_descriptor *desc, struct usb_interface_descriptor *iface,
int bus_seq, int devnum,
int bus_seq, int devnum, int port, struct udevice **devp)
Do we really need all these parameters passed to this function ? Can't we somehow infer the port number from one of them OR isn't there some structure we can already pass in it reduce the number of parameters ? It feels there is way too many of them.
The patch looks good though, this is more of a general design question.
Reviewed-by: Marek Vasut marex@denx.de