(trimming the CC list a bit)
Hi Suriyan,
On 3 November 2014 19:49, Suriyan Ramasami suriyan.r@gmail.com wrote:
The commands fatls/ext4ls give negative values when dealing with files greater than 2GB. The commands fatsize/ext4size do not update the variable filesize for these files.
To deal with this, the fs functions have been modified to take an additional parameter of type "* loff_t" which is then populated. The return value of the fs functions are used only for error conditions.
Thanks for the new series. Can you please post the expected output of this with all patches applied?
Changes in v6:
- Update expected results in comments
- Simon comments -
- Remove README file and add it in start of script
- Drop blank lines in top of functions
- Put repeating constants in lower case variables
- Refer to U-Boot as U-Boot
- Move settings to top of file and code in functions or otherwise at bottom
- Create check_prereq function
- Use mkfs -t <type> -F <img> for ext4, but modify for fat
- Simon - Split this into a separate patch
- Simon - Split this into a separate patch
- Simon - Split this into a separate patch
- Simon - Split this into a separate patch
- Simon - Split this into a separate patch
Changes in v5:
- Simon comments -
- Add README file to document how to run it
- Generate output in a sandbox environment
- Add one line comments on shell variables used
- Avoid camel case through out
- Path to UBOOT is variable at top
- Print PASSED or FAILED at end, and set return code, 0 if OK, 1 otherwise
- Simon - update fs.h with comments for fs_read/fs_write/fs_size
Suriyan Ramasami (6): sandbox: script for testing sandbox/ext4/fat/fs commands fs: interface changes to accomodate files greater than 2GB fat: interface changes to accomodate files greater than 2GB ext4: interface changes to accomodate files greater than 2GB sandbox: Use md5sum and fatwrite to enable testing of fs commands sandbox: interface changes to accomodate files greater than 2GB
arch/sandbox/cpu/os.c | 13 +- arch/sandbox/cpu/state.c | 8 +- common/board_f.c | 8 +- common/cmd_ext4.c | 61 +---- common/cmd_fat.c | 9 +- common/cmd_fs.c | 17 ++ common/cmd_md5sum.c | 12 +- common/env_fat.c | 4 +- fs/ext4/ext4_common.c | 24 +- fs/ext4/ext4_common.h | 4 +- fs/ext4/ext4_write.c | 32 +++ fs/ext4/ext4fs.c | 37 +-- fs/fat/fat.c | 122 +++++----- fs/fat/fat_write.c | 61 ++--- fs/fat/file.c | 7 +- fs/fs.c | 77 ++++--- fs/sandbox/sandboxfs.c | 73 ++++-- include/configs/sandbox.h | 2 + include/ext4fs.h | 13 +- include/fat.h | 19 +- include/fs.h | 41 ++-- include/os.h | 5 +- include/sandboxfs.h | 14 +- test/fs/fs-test.sh | 562 ++++++++++++++++++++++++++++++++++++++++++++++ 24 files changed, 943 insertions(+), 282 deletions(-) create mode 100755 test/fs/fs-test.sh
-- 1.9.1
Regards, Simon