Re: [U-Boot] [PATCH v3 09/10] kconfig: move CONFIG_OF_* to Kconfig

Hi Masahiro,

On 22 September 2014 04:59, Masahiro Yamada yamada.m@jp.panasonic.com wrote:

This commit moves: CONFIG_OF_CONTROL CONFIG_OF_SEPARATE CONFIG_OF_EMBED CONFIG_OF_HOSTFILE

Because these options are currently not supported for SPL, the "Device Tree Control" menu does not appear in the SPL configuration.

Note: zynq-common.h should be adjusted so as not to change the default value of CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME.

Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org Cc: Stephen Warren swarren@nvidia.com Cc: Minkyu Kang mk7.kang@samsung.com Cc: Michal Simek michal.simek@xilinx.com

From the bits that I understand (not zynq and microblaze)

Acked-by: Simon Glass sjg@chromium.org

But please see a request below:

[snip]

diff --git a/dts/Kconfig b/dts/Kconfig new file mode 100644 index 0000000..20be556 --- /dev/null +++ b/dts/Kconfig @@ -0,0 +1,48 @@ +# +# Device Tree Control +# +# TODO: +# This feature is not currently supported for SPL, +# but this restriction should be removed in the future.

+config SUPPORT_OF_CONTROL

•   bool
  

+menu "Device Tree Control"

•   depends on !SPL_BUILD
  

•   depends on SUPPORT_OF_CONTROL
  

+config OF_CONTROL

•   bool "Run-time configuration via Device Tree"
  

•   help
  

•     This feature provides for run-time configuration of U-Boot
  

•     via a flattened device tree.
  

+choice

•   prompt "Provider of DTB for DT control"
  

•   depends on OF_CONTROL
  

+config OF_SEPARATE

•   bool "Separate DTB for DT control"
  

•   depends on !SANDBOX
  

•   help
  

•     If this option is enabled, the device tree will be built and
  

•     placed as a separate u-boot.dtb file alongside the U-Boot image.
  

+config OF_EMBED

•   bool "Embedded DTB for DT control"
  

•   help
  

•     If this option is enabled, the device tree will be picked up and
  

•     built into the U-Boot image.
  

Can you please add " This is suitable for debugging and development only and is not recommended for production devices."

+config OF_HOSTFILE

•   bool "Host filed DTB for DT control"
  

•   depends on SANDBOX
  

•   help
  

•     If this option is enabled, DTB will be read from a file on startup.
  

•     This is only useful for Sandbox.  Use the -d flag to U-Boot to
  

•     specify the file to read.
  

+endchoice

+endmenu

Regards, Simon