On Wed, 2015-12-23 at 02:47 +0100, Marek Vasut wrote:
On Wednesday, December 23, 2015 at 02:36:13 AM, Chin Liang See wrote:
On Wed, 2015-12-23 at 01:47 +0100, Marek Vasut wrote:
On Wednesday, December 23, 2015 at 01:21:31 AM, Chin Liang See wrote:
On Tue, 2015-12-22 at 21:28 +0100, Marek Vasut wrote:
On Tuesday, December 22, 2015 at 08:32:29 AM, Chin Liang See
wrote:
[..]
I will drop this patch and fix the remaining three during application, since I want to get this set out of the door, but please do some better testing next time.
Do share you build error so I can simulate the build error.
CONFIG_SPI_FLASH_USE_4K_SECTORS was used twice in the config file sockit config file (configs/socfpga_sockit) .
Oh I believe its commented out.
bash-3.2$ git grep --color CONFIG_SPI_FLASH_USE_4K_SECTORS configs/socfpga_arria5_defconfig:CONFIG_SPI_FLASH_USE_4K_SECTORS=n configs/socfpga_cyclone5_defconfig:CONFIG_SPI_FLASH_USE_4K_SECTORS= n configs/socfpga_sockit_defconfig:# CONFIG_SPI_FLASH_USE_4K_SECTORS is not set configs/socfpga_sockit_defconfig:CONFIG_SPI_FLASH_USE_4K_SECTORS=n
But it's twice in there. Also, =n is not valid construct, to disable config option you should comment it out the way it's done above.
Oh unaware the =n is invalid. Thanks for the fix.
Chin Liang
configs/socfpga_sr1500_defconfig:CONFIG_SPI_FLASH_USE_4K_SECTORS=n drivers/mtd/spi/sf_internal.h:#ifdef CONFIG_SPI_FLASH_USE_4K_SECTORS
Thanks Chin Liang
Best regards, Marek Vasut