Re: [PATCH 1/3] acpi: fix FADT table

On Fri, Dec 15, 2023 at 05:40:14PM +0100, Heinrich Schuchardt wrote:

Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to to uintptr_t to fill these.

If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. We should not fill unused fields.

Is it dictated by the specifications? Please, put the reference here in the commit message (section X.Y.Z "Goo bar").

...

From code perspective LGTM.