With gcc-6 and later we see a warning about the fact that we have a construct of "if (test);\n\tstatement". Upon reviewing the code, the intention here is as the compiler suggests, we only want to execute the indented statement if the test was true.
Cc: Sergei Poselenov sposelenov@emcraft.com Signed-off-by: Tom Rini trini@konsulko.com --- board/socrates/socrates.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/socrates/socrates.c b/board/socrates/socrates.c index 8b34a80e8f72..fb691c22d961 100644 --- a/board/socrates/socrates.c +++ b/board/socrates/socrates.c @@ -378,7 +378,7 @@ static void board_backlight_brightness(int br)
/* LEDs on */ reg = in_be32((void *)(CONFIG_SYS_FPGA_BASE + 0x0c)); - if (!(reg & BACKLIGHT_ENABLE)); + if (!(reg & BACKLIGHT_ENABLE)) out_be32((void *)(CONFIG_SYS_FPGA_BASE + 0x0c), reg | BACKLIGHT_ENABLE); } else {