Alper Nebi Yasak alpernebiyasak@gmail.com writes:
On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
The current code is setting the clock rate to 192000000, but due to the current device-tree configuration and linux code, it should rather be 100000000.
This looks like it's ACLK_VOP to me. FYI, coreboot sets it to 192 MHz for rk3288 and 200 MHz for rk3399. But from what I can understand the U-Boot rk3399 clock driver just ignores this call and sets it to 198 MHz anyway while setting DCLK_VOP...
In a perfect world, the rate should not be hardcoded and everyone should rely on devicetree. Again, fixing that is more for a different patchset than rk3399 edp support imho. If it makes things easier, I'll test my patchset on my PBP without this change and possibly drop this patch.
Arnaud