Hi,
On 26-04-15 05:33, Ian Campbell wrote:
On Fri, 2015-04-24 at 15:48 +0200, Hans de Goede wrote:
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index 3831d3b..3997637 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -529,4 +529,16 @@ config GMAC_TX_DELAY ---help--- Set the GMAC Transmit Clock Delay Chain value.
+config NET
- default y
+config NETDEVICES
- default y
+config DM_ETH
- default y
+config DM_SERIAL
- default y
None of these have a more appropriate home than sunxi/Kconfig?
The CONFIG_foo options themselves are defined in more appropriate places, we are just enabling them for all sunxi boards here.
Another way would be to add "default y if ARCH_SUNXI" to the place where they are actually defined.
Doing things this way was copied from arch/sandbox/Kconfig, I've tried using select in arch/arm/Kconfig for the NET ones but that leads to:
warning: (ARCH_SUNXI) selects NET which has unmet direct dependencies (SANDBOX) warning: (ARCH_SUNXI) selects NET which has unmet direct dependencies (SANDBOX)
Which really seems to be an issue with the SANDBOX Kconfig file to me, which has:
menu "Sandbox architecture" depends on SANDBOX
...
config NET default y
config NETDEVICES default y
config DM_ETH default y
...
endmenu
I would be happy to see this fixed, but for now I've just copied what the sandbox code is doing.
Regards,
Hans