Shinya Kuribayashi wrote:
Dear Vlad,
There are some coding style issues, but I'm fine with contents of the patch itself. Please find comments below and resubmit.
My God, you are worse than ze germans! Sorry Wolfgang, I had to say it :-)
[snip]
please update .lds to the latest board/dbau1x00/u-boot.lds, etc. I'd like to see . = .;
What does this do ?
_gp = ALIGN(16) + 0x7ff0; and .u_boot_cmd : { __u_boot_cmd_start = .; *(.u_boot_cmd) __u_boot_cmd_end = .; } and so on. I understand it works well without such changes, but it's better to keep all target together.
Any opinions on using a single ldscript per platform, eventually preprocessed with gcc -E to allow for board-specific differences? At least for MIPS, all scripts are essentally the same.
As for the style issues, some are mine, but many are in the code I copied from. Anyway, I fixed them. Patch to follow.
Regards, Vlad