Hi,
On 19-10-15 12:38, Stefan Roese wrote:
Hi Hans,
On 17.10.2015 15:47, Hans de Goede wrote:
On 01-10-15 11:41, Stefan Roese wrote:
The ICnova-A20-SWAC is a baseboard, equipped with the ICnova-A20 SoM from In-Circuit:
http://wiki.in-circuit.de/index.php5?title=ICnova_A20_SODIMM http://linux-sunxi.org/In-Circuit_ICnova_A20
This patch adds support for this board, including ethernet, LCD and USB support.
Thanks, I've merged this and it will show up in u-boot-sunxi/next soon.
Thanks.
I've made 2 small changes, see comments inline.
<snip>
diff --git a/configs/icnova-a20-swac_defconfig b/configs/icnova-a20-swac_defconfig new file mode 100644 index 0000000..bd6e0c5 --- /dev/null +++ b/configs/icnova-a20-swac_defconfig @@ -0,0 +1,21 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_MACH_SUN7I=y +CONFIG_DRAM_CLK=384 +CONFIG_OLD_SUNXI_KERNEL_COMPAT=y
I've dropped this, I understand that you need it, but I do not believe that ANY defconfig's as shipped upstream should set this.
Hmmm. I would prefer to have this added to the defconfig as well. As it very likely leads to confusion when updating to a newer U-Boot version which will not support the old kernel. Why not give the users / maintainers the freedom to choose this for themselves?
Users are free to choose this, they can always enable this themselves after running make foo_defconfig.
As for why not give the MAINTAINERS a choice on this, as said I believe that we should not shipp defconfigs with this set by default as part of mainline u-boot. The reasons for this are:
1) It is inconsistent with what we are doing for all other sunxi boards where we are primarily targetting mainline
2) It communicates that CONFIG_OLD_SUNXI_KERNEL_COMPAT is an officially supported end-user feature, where as in reality it is targeted at developers who need to run an old sunxi kernel every now and then to see how that kernel exactly programs certain registers, etc.
3) It means we ship with a severely crippled defconfig for mainline kernel users, mainline users will loose both smp and hyp mode support on the A20 when this option is set.
I'm sorry but I'm not going to budge on this one, having CONFIG_OLD_SUNXI_KERNEL_COMPAT=y in a defconfig is simply not acceptable IMHO. It is not a board specific thing, and there are very good reasons why it defaults to n in board/sunxi/Kconfig
+CONFIG_MMC0_CD_PIN="PI5" +CONFIG_USB0_VBUS_PIN="PG11" +CONFIG_USB0_VBUS_DET="PH7" +CONFIG_USB1_VBUS_PIN="PG10" +CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:24,pclk_khz:33000,le:45,ri:209,up:22,lo:22,hs:1,vs:1,sync:3,vmode:0"
+CONFIG_VIDEO_LCD_POWER="PH22" +CONFIG_VIDEO_LCD_PANEL_LVDS=y +CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-icnova-a20-swac" +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set +CONFIG_SPL=y +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_GMAC,CMD_BMP,CMD_UNZIP"
I've dropped AXP209_POWER from these, in u-boot-sunxi/next this has been turned into a Kconfig bool which is enabled by default on sun7i.
Understood.
Thanks, Stefan
Regards,
Hans