Re: [U-Boot] [PATCH v3 08/10] sun5/7i: add an implementation of the psci suspend function

On Thu, Oct 27, 2016 at 03:20:02PM +0200, Maxime Ripard wrote:

On Thu, Oct 27, 2016 at 03:10:58PM +0200, Antoine Tenart wrote:

...

On Wed, Oct 26, 2016 at 02:38:10PM +0200, Maxime Ripard wrote:

...

On Wed, Oct 26, 2016 at 02:10:31PM +0200, Antoine Tenart wrote:

...

+#ifndef CONFIG_MACH_SUN7I

• /* switch cpuclk to losc */
• clrbits_le32(&ccm->cpu_ahb_apb0_cfg, 0x3 << CPU_CLK_SRC_SHIFT);

+#endif

Some kind of comment here would be nice.

That's based on my experiments, switching the cpu clk to losc wasn't working (the board hanged). I agree that's not the best explanation ever...

Still, even if that's only to say that it was based on experiments and you don't really know why. It's definitely not obvious to anyone, so it deserves a comment to explain why you did it that way.

Sure, I wasn't arguing about the need of a comment :)

Antoine