Re: [U-Boot] [PATCH] Avoid using GNU basename

Dear Keith Mok,

In message CAHjoi4eR+n=qQ8vZAKwwgLiPSFfrBWHRHwYNvfJn4y0F9EqO7g@mail.gmail.com you wrote:

There is no GNU basename support in MacOS. Use generic POSIX basename defined in libgen.h instead.

...

    int fp, ep;
    const char *prg;

•   char *prog_pathname;
  
  

•   prg = basename(argv[0]);
  

•   prog_pathname = strdup(argv[0]);
  

•   prg = basename(prog_pathname);
  

free() missing. Actually the strdup should not be needed at all, as we don't use argv[0] after that - at least we shouldn't. The remaining "usage(argv[0]);" should be fixed instead.

Besides - I agree with Mike's comment how your MacOS issue should be fixed.

Best regards,

Wolfgang Denk