5 Jan
2013
5 Jan
'13
8:50 p.m.
Dear Anatolij,
In message 1357415148-9243-1-git-send-email-wd@denx.de you wrote:
lcd_color_fg and lcd_color_bg had to be declared in board specific code, but were not actually used there; in addition, we have getter / setter functions for these, which were not used either.
Get rid of the global variables, and use the getter function where needed (so far no setter calls are needed).
A similar change could (and probably should?) be implemented for lcd_base, too - but thjis requires a little more code changes, plus the introduction of both getter and setter functions.
Do you think this should be done? If so, I would prepare a patch... [Otherwise I'd save the effort...]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Motto of the Electrical Engineer: Working computer hardware is a lot
like an erect penis: it stays up as long as you don't fuck with it.