On Sun, Jul 25, 2004 at 12:31:26PM +0300, Yuli Barcohen wrote:
Lars Munch writes:
Lars> The attached patch fixes cygwin builds. inttypes.h has been Lars> included in cygwin for quite some time now, so we do not need Lars> all the __WIN32__ ifdef's.First of all, Cygwin is a Linux-like environment and not WIN32 so there is no need to #define __WIN32__ in the Makefile.
That is true, but on older cygwin systems that define was needed in order to build the tools. To me it looks like __WIN32__ should have been named __CYGWIN__ in the first place, since all the "#ifdef __WIN32__" in the tools directory are cygwin related and not VC++ nor mingw related.
Maybe we should just remove all the "#ifdef __WIN32__" from the tools directory since they are not needed any more for cygwin builds and has nothing to do VC++ nor mingw?
#ifdefs can be needed for other environments (mingw? Visual C?). The problem is in the order of header files because U-Boot host tools have to mix target and host headers and in some cases (including Cygwin) wrong files are #included. My patch from Jul 19th fixes this problem.
Sorry, I forgot about your patch.
-- Lars Munch