Hi Nikhil,
Thanks for the patch.
On 29/03/23 17:31, Nikhil M Jain wrote:
Change rule to compile bmp_cmd when CONFIG_CMD_BMP is defined, in place of bmp.c.
Signed-off-by: Nikhil M Jain n-jain1@ti.com
V4:
- No change
V3 (patch introduced):
- Rule to compile bmp_cmd.c
cmd/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/Makefile b/cmd/Makefile index 36d2daf22a..c773acb1a1 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -29,7 +29,7 @@ obj-$(CONFIG_CMD_BIND) += bind.o obj-$(CONFIG_CMD_BINOP) += binop.o obj-$(CONFIG_CMD_BLOBLIST) += bloblist.o obj-$(CONFIG_CMD_BLOCK_CACHE) += blkcache.o -obj-$(CONFIG_CMD_BMP) += bmp.o
I think we are breaking backward compatibility here, the platforms only enabled CONFIG_CMD_BMP in defconfig.
+obj-$(CONFIG_CMD_BMP) += bmp_cmd.o
I think you should add bmp.o too in above to preserve backward compatibility.
Regards Devarsh