Hi Philipp,
On 25 Jan 2018, at 18:37, Lukasz Majewski lukma@denx.de wrote:
From: Anatolij Gustschin agust@denx.de
Selecting this option will reduce SPL boot time by approx. 6 ms (e. g. with 70 bytes long banner string at 115200 baud).
Signed-off-by: Anatolij Gustschin agust@denx.de Tested-by: Lukasz Majewski lukma@denx.de
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
See below for a nitpick.
common/spl/Kconfig | 7 +++++++ common/spl/spl.c | 2 ++ 2 files changed, 9 insertions(+)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig index d686b1ecbd..d1f9cae6b7 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -118,6 +118,13 @@ config SPL_SEPARATE_BSS location is used. Normally we put the device tree at the end of BSS but with this option enabled, it goes at _image_binary_end.
+config SPL_DISABLE_BANNER_PRINT
- bool "Disable output of the SPL banner 'U-Boot SPL ...'"
- help
If this option is enabled, SPL will not print the bannerwith version
info. Selecting this option could be useful to reduceSPL boot time
(e.g. approx. 6 ms slower, when output on i.MX6 with1152000 baud).
You seem to be off by “times 10” for the baud-rate.
Extra boost :-)
Fixed in v2. Thanks for spotting.
config SPL_DISPLAY_PRINT bool "Display a board-specific message in SPL" help diff --git a/common/spl/spl.c b/common/spl/spl.c index 76c1963611..898c416a66 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -477,8 +477,10 @@ void preloader_console_init(void)
gd->have_console = 1;
+#ifndef CONFIG_SPL_DISABLE_BANNER_PRINT puts("\nU-Boot SPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \ U_BOOT_TIME ")\n"); +#endif #ifdef CONFIG_SPL_DISPLAY_PRINT spl_display_print();
#endif
2.11.0
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de