HI Lukasz
2017-05-02 18:47 GMT+08:00 Lukasz Majewski lukma@denx.de:
Hi Eddie,
Hi Lukasz
2017-04-30 5:46 GMT+08:00 Lukasz Majewski lukma@denx.de:
On Sat, 29 Apr 2017 08:41:34 +0800 Eddie Cai eddie.cai.linux@gmail.com wrote:
rockusb is a protocol run between host pc and device. it help people get device info, flash image to device. this patch implement rockusb on device side
Changes in v3: -switch back to use g_dnl code -address comment from Lukasz and Simon -fix checkpatch error
Changes in v2: -switch to use usb masstorage framework -add readme for rockusb
Eddie Cai (4): usb: rockchip: add the rockusb gadget usb: rockchip: add rockusb command rockchip:usb: add a simple readme for rockusb rockchip: usb: enable rockusb on rk3288 based board
arch/arm/include/asm/arch-rockchip/f_rockusb.h | 104 ++++ cmd/Kconfig | 11 + cmd/Makefile | 1 + cmd/rockusb.c | 74 +++ configs/evb-rk3288_defconfig | 3 + configs/fennec-rk3288_defconfig | 2 + configs/firefly-rk3288_defconfig | 2 + configs/miqi-rk3288_defconfig | 2 + configs/popmetal-rk3288_defconfig | 2 + configs/rock2_defconfig | 3 + configs/sandbox_defconfig | 3 +- configs/tinker-rk3288_defconfig | 2 + doc/README.rockusb | 37 ++ drivers/usb/gadget/Makefile | 1 + drivers/usb/gadget/f_rockusb.c | 724 +++++++++++++++++++++++++ 15 files changed, 970 insertions(+), 1 deletion(-) create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h create mode 100644 cmd/rockusb.c create mode 100644 doc/README.rockusb create mode 100644 drivers/usb/gadget/f_rockusb.c
I've built test your patches for "rockchip" and following errors emerged:
^^^^^^^^^^^^^^^^^^^^ [1]Please fix those issues.
I don't understand how you got those error.
In the last commit you have enabled the "rockchip" protocol support for other RK boards.
Have you checked if it is possible to build those boards after your change?
To avoid build break regressions we do use "buildman".
For this test I've build all "rockchip" devices (as marked in boards.cfg file).
After applying your patches I've found following errors -> [1]
The buildman configuration can be read from log posted in [1].
Here is my test branch git clone https://github.com/eddiecailinux/u-boot -b rockusb-v3 i use below command to build u-boot CROSS_COMPILE=arm-linux-gnueabihf- make firefly-rk3288_defconfig all
But this is only for one single board -> firefly-rk3288. You also should check if other boards are not affected by your code.
got it. thanks for reminding.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de