
13 Dec
2008
13 Dec
'08
9:33 p.m.
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 1229198787-24017-1-git-send-email-plagnioj@jcrosoft.com you wrote: ...
+static void __inline__ wait_ms(unsigned long ms) +{
- while(ms-->0)
White space before and after the '>', please.
And should we not check for a '0' argument first? Of course, you can argument that the caller will just get what he asked for (i. e. a nearly 50 days delay), but anyway.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It is much easier to suggest solutions when you know nothing