-----Original Message----- From: Pali Rohár pali@kernel.org Sent: Thursday, July 6, 2023 7:51 PM To: Jaehoon Chung jh80.chung@samsung.com; Tom Rini trini@konsulko.com Cc: Peng Fan peng.fan@nxp.com; Stefan Roese sr@denx.de; u-boot@lists.denx.de Subject: Re: [PATCH u-boot 0/4] mmc: Explain and cleanup partition selection
On Monday 03 July 2023 21:16:37 Jaehoon Chung wrote:
Hi,
On 4/14/23 06:10, Pali Rohár wrote:
Some people do not want to read review comments in emails. So put comments and explanation into the source code itself; make emmc partition selection code more explicit and validate configuration in bubt command.
Sorry for too late. After applied this patch-set, some board are failed with spl's size overflowed
The below is one of failed log.
+arm-linux-gnueabi-ld.bfd: region `.sram' overflowed by 352 bytes +make[2]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1 +make[1]: *** [Makefile:2049: spl/u-boot-spl] Error 2
Crap, and again we have there same issue. Patch after months does not apply anymore. And resending the patch would again result in the same problem that it would not apply anymore after half of the year...
Anyway, only first patch is SPL specific, other should apply without any problem.
Except spl specific patch, I will check again about your other patches. Thanks!
Best Regards, Jaehoon Chung
Best Regards, Jaehoon Chung
Pali Rohár (4): mmc: spl: Make partition choice in default_spl_mmc_emmc_boot_partition() more explicit cmd: mvebu/bubt: Validate EXT_CSD[179] eMMC register in mmc_burn_image() sunxi: eMMC: Add comments explaining mapping between bootpart and mmc_switch_part() board: purism: Use U-Boot mmc function for converting boot part to part access
arch/arm/mach-sunxi/board.c | 12 ++++++++++- board/purism/librem5/librem5.c | 6 +----- cmd/mvebu/bubt.c | 24 +++++++++++++++++++-- common/spl/spl_mmc.c | 38 +++++++++++++++++++++++++++------- 4 files changed, 64 insertions(+), 16 deletions(-)