Hi Jerry,
On Wednesday 19 December 2007, Jerry Van Baren wrote:
Disclaimer: I am not a OF expert, I have not read the OF documentation cover to cover and do not understand many implications of what I've read, much less what I have _not_ read.
- I believe the /chosen node should be auto-created.
Ufff. :)
- As you point out, if the /chosen node already exists the current code
bails out and doesn't change anything. This was done as a very badly misguided attempt to make libfdt things work like bd_t things. The granularity should be on the individual properties, not on /chosen. I consider this a bug and have it on my "todo" list to fix (actually, I had created a patch, but I need to rebase and publish it).
http://www.denx.de/wiki/view/UBoot/UBootFdtInfo#Outstanding_Patches
"Unpublished patch of JerryVanBaren, implementing a suggestion by Scott Wood to make the /chosen handling finer grained: if the /chosen node exists, currently u-boot-fdt bails out. A better methodology is to not overwrite pre-existing properties on a per-property basis, so if /chosen exists but a necessary /chosen/property doesn't, it gets created. Good idea, but not published and poorly tested at the moment."
OK, thanks for these infos.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================