On Tue, 10 Jan 2023 at 09:19, Tom Rini trini@konsulko.com wrote:
In the case of DM_SERIAL and not having CONFIG_SYS_NS16550_REG_SIZE defined, we would set CONFIG_SYS_NS16550_REG_SIZE to -1 with a comment that this isn't really needed. This implies that the reason we set something here is so that we have UART_REG defined and so can use the rest of the structures that are shared between all the users of ns16650.h. In order to not #define a CONFIG variable here, instead move that check over to the CONFIG_NS16550_DYNAMIC case (which is at the conceptual level, similar to DM) to get UART_REG defined.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
I'm making an assumption, in the end, as to what the DM case is doing. This does work in my lab.
include/ns16550.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)'
Reviewed-by: Simon Glass sjg@chromium.org
Seems OK, although this patch brings back nightmares from last time I was in there.
- Simon